Use less permissive types in the config monoids (#2267) #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es ASAP This entails a behavior change when the argument to the 'docker-stack-exe' option cannot be parsed: Previously the option was ignored in this case, now an exception is thrown. Side effects of this change: * StackDockerException is moved to Stack.Types.Docker, so parseDockerStackExe can throw a proper exception * Stack.Nix.CannotDetermineProjectRootException is renamed because Stack.Types.Docker.CannotDetermineProjectRootException has moved into the same scope.
sjakobi
force-pushed
the
2267-less-permissive-config-monoids
branch
from
b0738ac to
6218dad
Compare
|
Because I would prefer not to rebase this PR again and because apart from 72e0fa3 I'm pretty sure there's no change in behaviour*, I'll merge this myself if no one feels like reviewing this. *: Of course, some bad inputs are caught earlier now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a review it's probably best to look at each commit in sequence.
See #2267 for the original issue.